Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PagoPA-1607] - java 17 migration #94

Merged
merged 11 commits into from
Mar 22, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

@alessio-acitelli alessio-acitelli commented Mar 15, 2024

depends on: PR integration test

List of Changes

  • upgrade to java 17

Motivation and Context

  • java 11 has been deprecated by sonar

How Has This Been Tested?

  • manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

pagopa-github-bot and others added 7 commits March 13, 2024 12:43
https://github.com/pagopa/pagopa-gpd-payments into PAGOPA-1497-int-test

Conflicts:
	integration-test/src/step_definitions/support/clients/api_config_client.js
	integration-test/src/step_definitions/support/logic/gpd_logic.js
	integration-test/src/step_definitions/support/utility/request_builders.js
https://github.com/pagopa/pagopa-gpd-payments into PAGOPA-1497-int-test

Conflicts:
	integration-test/src/step_definitions/support/clients/api_config_client.js
	integration-test/src/step_definitions/support/logic/gpd_logic.js
	integration-test/src/step_definitions/support/utility/request_builders.js
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@alessio-acitelli alessio-acitelli marked this pull request as ready for review March 15, 2024 14:58
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner March 15, 2024 14:58
@pasqualespica pasqualespica merged commit 9edbea0 into main Mar 22, 2024
11 of 16 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-1607-java-17-migration branch March 22, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants